tustvold commented on code in PR #3756:
URL: https://github.com/apache/arrow-rs/pull/3756#discussion_r1115827290
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -632,4 +690,83 @@ mod tests {
let buffer = Buffer::from(MutableBuffer::from_len_zeroed(12));
buffer.slice_with_length(2, usize::MAX);
}
+
+ #[test]
+ fn test_vec_interop() {
Review Comment:
Adding Vec conversion at the `Buffer` level does allow for transmuting types
provided they have the same layout, this is perhaps not ideal but isn't
harmful.
Long-term I hope to deprecate and remove `Buffer` and `MutableBuffer`, just
leaving `ScalarBuffer` which statically prevents this sort of type-conversion,
but doing it this way allows for a gradual migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
