tustvold commented on code in PR #3756:
URL: https://github.com/apache/arrow-rs/pull/3756#discussion_r1118778172


##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -632,4 +690,83 @@ mod tests {
         let buffer = Buffer::from(MutableBuffer::from_len_zeroed(12));
         buffer.slice_with_length(2, usize::MAX);
     }
+
+    #[test]
+    fn test_vec_interop() {

Review Comment:
   Nope, there is a good justification for why this is perfectly fine 
[here](https://doc.rust-lang.org/std/primitive.f32.html#method.from_bits). The 
only place where this becomes problematic is where types have bit sequences 
that illegal, e.g. NonZeroU32 or bool, all `ArrowNativeType` are valid for all 
bit sequences.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to