comphead commented on code in PR #5377:
URL: https://github.com/apache/arrow-datafusion/pull/5377#discussion_r1117375837
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -216,23 +216,19 @@ impl Accumulator for DistinctCountAccumulator {
}
fn size(&self) -> usize {
+ // temporarily calculating the size approximately, taking first batch
size * number of batches
+ // such approach has some inaccuracy for variable length values, like
strings.
Review Comment:
Right, as we agreed in
https://github.com/apache/arrow-datafusion/issues/5325#issuecomment-1441767680
We need a fix the benchmark and later @alamb can think how to deal with
variable length data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
