jychen7 commented on code in PR #5377:
URL: https://github.com/apache/arrow-datafusion/pull/5377#discussion_r1117930258
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -216,23 +216,19 @@ impl Accumulator for DistinctCountAccumulator {
}
fn size(&self) -> usize {
+ // temporarily calculating the size approximately, taking first batch
size * number of batches
+ // such approach has some inaccuracy for variable length values, like
strings.
Review Comment:
> Instead add some code that checks "if is ScalarType::Int8, UInt8, etc then
size = size[0]*vec.len()"
https://github.com/apache/arrow-datafusion/issues/5325#issuecomment-1435672826
are we missing this check in this PR? so we still have accurate size (slow
for now) for variable data and accurate size (fast) for fixed lenth data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
