rtpsw commented on PR #34311: URL: https://github.com/apache/arrow/pull/34311#issuecomment-1444389630
> Also, can we add at least one or two basic end-to-end tests in `plan_test.cc` (or you could create an `aggregate_node_test.cc`). Partly as examples for future readers as much as anything. My [recent commit](https://github.com/apache/arrow/pull/34311/commits/70acbe6697206ff378e40d1552c70bf77ee335f1) should have the requested fixes except the above one for adding tests (TBD). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org