tustvold commented on code in PR #3763:
URL: https://github.com/apache/arrow-rs/pull/3763#discussion_r1118709665
##########
arrow-string/src/concat_elements.rs:
##########
@@ -156,10 +158,35 @@ pub fn concat_elements_utf8_many<Offset: OffsetSizeTrait>(
Ok(unsafe { builder.build_unchecked() }.into())
}
+pub fn concat_elements_dyn(
+ left: &dyn Array,
+ right: &dyn Array,
+) -> Result<ArrayRef, ArrowError> {
+ if left.data_type() != right.data_type() {
+ return Err(ArrowError::ComputeError(format!(
+ "Cannot concat arrays of different types: {} != {}",
+ left.data_type(),
+ right.data_type()
+ )));
+ }
+ match (left.data_type(), right.data_type()) {
Review Comment:
Perhaps we could also handle when the arrays are both `LargeUtf8`? Otherwise
this is not all that different from the normal kernel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
