tustvold commented on code in PR #3763:
URL: https://github.com/apache/arrow-rs/pull/3763#discussion_r1124307991
##########
arrow-string/src/concat_elements.rs:
##########
@@ -156,6 +158,93 @@ pub fn concat_elements_utf8_many<Offset: OffsetSizeTrait>(
Ok(unsafe { builder.build_unchecked() }.into())
}
+pub fn concat_element_binary<Offset: OffsetSizeTrait>(
+ left: &GenericBinaryArray<Offset>,
+ right: &GenericBinaryArray<Offset>,
+) -> Result<GenericBinaryArray<Offset>, ArrowError> {
+ if left.len() != right.len() {
Review Comment:
I think this logic can be combined into a `concat_element_bytes` I'll see
what I can come up with in a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
