crepererum opened a new pull request, #5419: URL: https://github.com/apache/arrow-datafusion/pull/5419
# Which issue does this PR close? Closes #4695. # Rationale for this change Use `Arc<dyn PhysicalExpr>` instead of `Expr` within `ParquetExec` and move lowering from logical to physical expression into plan lowering (e.g. `ListingTable`). This is in line w/ all other physical plan nodes (e.g. `FilterExpr`) and simplifies reasoning within physical optimizer but also allows correct passing of `ExecutionProps` into the conversion. # What changes are included in this PR? Basically a bunch of type changes. The tests still use logical expressions because they are easier to construct and its a simple conversion from logical to phys. (at least in the test cases). # Are these changes tested? All existing tests pass. Removed tests that no longer apply. Added one to demonstrate `PruningPredicate` behavior when no columns are referenced (see https://github.com/apache/arrow-datafusion/pull/5386#discussion_r1117641476 ). # Are there any user-facing changes? - Phys. plan printouts look slightly differently. - **BREAKING:** Serialization has changed. - **BREAKING:** `ParquetExec` arguments changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
