crepererum commented on code in PR #5419:
URL: https://github.com/apache/arrow-datafusion/pull/5419#discussion_r1118885925
##########
datafusion/core/src/physical_plan/file_format/parquet/row_filter.rs:
##########
@@ -391,36 +391,14 @@ pub fn build_row_filter(
mod test {
use super::*;
use arrow::datatypes::Field;
- use datafusion_expr::{cast, col, lit};
+ use datafusion_common::ToDFSchema;
+ use datafusion_expr::{cast, col, lit, Expr};
+ use datafusion_physical_expr::create_physical_expr;
+ use datafusion_physical_expr::execution_props::ExecutionProps;
use parquet::arrow::parquet_to_arrow_schema;
use parquet::file::reader::{FileReader, SerializedFileReader};
use rand::prelude::*;
- // Assume a column expression for a column not in the table schema is a
projected column and ignore it
Review Comment:
This test is no longer relevant because you cannot lower such expression
from logical to physical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
