andygrove commented on code in PR #687:
URL: https://github.com/apache/arrow-ballista/pull/687#discussion_r1118953966
##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -288,6 +305,22 @@ impl ShuffleWriterExec {
}
}
+#[async_trait]
+impl ShuffleWriter for ShuffleWriterExec {
Review Comment:
That's a good point. Maybe want I want for now is just an `ExecutionEngine`
trait with an `execute` method that returns the metadata with shuffle file
locations. I will give this some more thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
