andygrove commented on code in PR #687:
URL: https://github.com/apache/arrow-ballista/pull/687#discussion_r1120311299
##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -288,6 +305,22 @@ impl ShuffleWriterExec {
}
}
+#[async_trait]
+impl ShuffleWriter for ShuffleWriterExec {
Review Comment:
@thinkharderdev I have renamed the trait and made some other naming changes.
I also added the ExecutionEngine abstraction in this PR. PTAL when you have
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
