pitrou commented on PR #34323: URL: https://github.com/apache/arrow/pull/34323#issuecomment-1447947585
> Okay, I'll > > 1. Test Processing max-length: 8, 64, 1024 +1 > 2. Batch-size (num string processed): 512, 1024, 2048 Just reduce that to 512, 2048? Actually, is it even useful to vary the batch size? > 3. `"byte_array_bytes"` means the accumulated length of string a benchmark processed. Ok, but is it the memory footprint? Otherwise, it's probably not useful to output. > Do you think above argument is ok? Or it's still too much testcases? @pitrou > > (Personally, I just use `benchmark_filter` to run the case I expect to run ) Right, but in some cases you want to run all Parquet encoding benchmarks to check for a regression/improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
