alamb commented on code in PR #3788:
URL: https://github.com/apache/arrow-rs/pull/3788#discussion_r1123267191
##########
arrow-flight/src/sql/client.rs:
##########
@@ -83,13 +75,23 @@ impl FlightSqlServiceClient {
/// Creates a new HTTPs FlightSql Client that connects via TCP to a server
#[cfg(feature = "tls")]
- pub async fn new_with_endpoint(
- client_ident: Identity,
- server_ca: Certificate,
- domain: &str,
+ pub async fn new_with_tls_endpoint(
Review Comment:
That is what I would recommend and what I started to do in
https://github.com/apache/arrow-rs/pull/3401/files#diff-f9c519f51ac059c26fa8fb28b174ebf8d66169690758b6b8a53bcf13ec6acb58R132
Let me see if I can update that PR to get it looking better ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
