alamb commented on code in PR #3788:
URL: https://github.com/apache/arrow-rs/pull/3788#discussion_r1123286275
##########
arrow-flight/src/sql/client.rs:
##########
@@ -83,13 +75,23 @@ impl FlightSqlServiceClient {
/// Creates a new HTTPs FlightSql Client that connects via TCP to a server
#[cfg(feature = "tls")]
- pub async fn new_with_endpoint(
- client_ident: Identity,
- server_ca: Certificate,
- domain: &str,
+ pub async fn new_with_tls_endpoint(
Review Comment:
(that PR is too far gone, so I closed it). But I think the idea is still a
good one (take only an Endpoint) -- and it is consistent with the
`FlightClient`:
https://docs.rs/arrow-flight/34.0.0/arrow_flight/client/struct.FlightClient.html#method.new
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
