icexelloss commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1123688788
##########
cpp/src/arrow/compute/exec/aggregate_node.cc:
##########
@@ -697,13 +909,18 @@ class GroupByNode : public ExecNode, public TracedNode {
}
int output_task_group_id_;
+ std::unique_ptr<GroupingSegmenter> segmenter_;
Review Comment:
Please add documentation for the new members
##########
cpp/src/arrow/compute/exec/aggregate_node.cc:
##########
@@ -697,13 +909,18 @@ class GroupByNode : public ExecNode, public TracedNode {
}
int output_task_group_id_;
+ std::unique_ptr<GroupingSegmenter> segmenter_;
Review Comment:
Please add documentation for the all the new members
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
