wesm commented on a change in pull request #8703:
URL: https://github.com/apache/arrow/pull/8703#discussion_r527275663
##########
File path: cpp/src/arrow/ipc/feather_test.cc
##########
@@ -286,10 +286,13 @@ TEST_P(TestFeather, PrimitiveNullRoundTrip) {
std::vector<std::shared_ptr<Array>> expected_fields;
for (int i = 0; i < batch->num_columns(); ++i) {
ASSERT_EQ(batch->column_name(i), reader_->schema()->field(i)->name());
- StringArray str_values(batch->column(i)->length(), nullptr, nullptr,
- batch->column(i)->null_bitmap(),
- batch->column(i)->null_count());
- AssertArraysEqual(str_values, *result->column(i)->chunk(0));
+ ASSERT_OK_AND_ASSIGN(auto expected, MakeArrayOfNull(utf8(),
batch->num_rows()));
+ AssertArraysEqual(*expected, *result->column(i)->chunk(0));
+ // StringArray str_values(batch->column(i)->length(), nullptr,
nullptr,
+ // batch->column(i)->null_bitmap(),
+ // batch->column(i)->null_count());
+ // AssertArraysEqual(str_values, *result->column(i)->chunk(0),
Review comment:
I recall this question coming up in the past and I don't recall the
outcome, @xhochy do you remember?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
