pitrou commented on a change in pull request #8703:
URL: https://github.com/apache/arrow/pull/8703#discussion_r528210648
##########
File path: cpp/src/arrow/util/bitmap.h
##########
@@ -110,8 +110,8 @@ class ARROW_EXPORT Bitmap : public
util::ToStringOstreamable<Bitmap>,
///
/// TODO(bkietz) allow for early termination
template <size_t N, typename Visitor,
- typename Word =
- typename internal::call_traits::argument_type<0,
Visitor&&>::value_type>
+ typename Word = typename std::decay<
+ internal::call_traits::argument_type<0,
Visitor&&>>::type::value_type>
Review comment:
A previous version of this work used `VisitWords`, but it ended up
exhibiting bad performance (`VisitWords` might be too complex for the
compiler). Yes, this change is for the case where the visitor argument takes a
`const& std::array<...>`. Perhaps there's no advantage in doing so, but it's
better if it works anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
