rtpsw commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1127106593
##########
cpp/src/arrow/compute/kernels/hash_aggregate_test.cc:
##########
@@ -1917,57 +2243,7 @@ TEST(GroupBy, MinMaxBinary) {
}
}
-TEST(GroupBy, MinMaxFixedSizeBinary) {
Review Comment:
> can we not remove it then?
I'm asking @westonpace to help figure out whether we need one or both.
> The original test above is called "MinMaxBinary" and it seems you renamed
it to "MinMaxFixedSizeBinary" and deleted the original "MinMaxFixedSizeBinary"
test
The diff in this PR doesn't appear consistent with the current version in
the main branch. I don't know what should be the conflict resolution here and
so I'm asking @westonpace to help figure it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
