rtpsw commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1127111119
##########
cpp/src/arrow/compute/kernels/hash_aggregate_test.cc:
##########
@@ -2087,7 +2363,7 @@ TEST(GroupBy, AnyAndAll) {
auto keep_nulls_min_count =
std::make_shared<ScalarAggregateOptions>(/*skip_nulls=*/false,
/*min_count=*/3);
ASSERT_OK_AND_ASSIGN(Datum aggregated_and_grouped,
- RunGroupBy(
+ AltGroupBy(
Review Comment:
The [`AltGroupBy`
function](https://github.com/apache/arrow/pull/34311/files#diff-ec1e8907dfc3e636abecd3307879f331421e4f28f75e504f147826cebf04d7e0R1116-R1123)
chooses an alternative for the group-by invocation (via `GetParam()`). There
are 2 alternatives: `RunGroupByImpl` and `RunSegmentedGroupByImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
