westonpace commented on issue #34484:
URL: https://github.com/apache/arrow/issues/34484#issuecomment-1458926783

   CC @vibhatha if you have time to take a look.  For now we should just hide 
the augmented fields entirely from Substrait.  At the moment I'm thinking the 
simplest way to do this might be to place a project node after any scan node.  
The project node can then hide these fields.
   
   Then we can wait to fix it properly until we have the new scan node.
   
   I think the "proper" fix would be to key on the ReadRel's `baseSchema` 
property.  If the column is named __filename (or whatever) then we 
automatically assume they are asking for the augmented field and we deliver it. 
 This means a user can't use a column names `__filename` but that seems like a 
reasonable workaround until we decide to introduce the concept of "augmented 
fields" to Substrait (I can't imagine this happening anytime soon).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to