kylepbit commented on a change in pull request #8724:
URL: https://github.com/apache/arrow/pull/8724#discussion_r527968005
##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -993,6 +998,30 @@ class FlightClient::FlightClientImpl {
return Status::OK();
}
+ Status AuthenticateBasicToken(std::string username, std::string password,
+ std::pair<std::string, std::string>*
bearer_token) {
+ // Add bearer token factory to middleware so it can intercept the bearer
token.
+
middleware.push_back(std::make_shared<ClientBearerTokenFactory>(bearer_token));
Review comment:
This looks odd to create the shared pointer after you've passed in the
raw pointer....it seems like the method itself should take a shared pointer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
