kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527969900
########## File path: cpp/src/arrow/flight/client_header_auth_middleware.h ########## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// Interfaces for defining middleware for Flight clients. Currently +// experimental. + +#pragma once + +#include "arrow/flight/client_middleware.h" +#include "arrow/flight/client_auth.h" +#include "arrow/flight/client.h" + +#ifdef GRPCPP_PP_INCLUDE +#include <grpcpp/grpcpp.h> +#if defined(GRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS) +#include <grpcpp/security/tls_credentials_options.h> +#endif +#else +#include <grpc++/grpc++.h> +#endif + +#include <algorithm> +#include <iostream> +#include <cctype> +#include <string> + +const std::string AUTH_HEADER = "authorization"; Review comment: Do these need to be in the header, or should they be only in the CC. If in the header, I think they're created anew for each compilation unit, and thus should be defined as extern with the actual value defined in the CC to avoid multiple instantiations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
