yahoNanJing commented on PR #5543: URL: https://github.com/apache/arrow-datafusion/pull/5543#issuecomment-1463685172
> This seems to have non-trivial overlap with ObjectStoreProvider, I wonder if we could combine them? The `ObjectStoreProvider` and `ObjectStoreManager` are for different aspects. As described in the code, `ObjectStoreProvider` focuses to get `ObjectStore` when it's not found in cache. While `ObjectStoreManager` focuses on the polymorphism of how to get an `ObjectStore` by `get_by_url`. The main reason to introduce `ObjectStoreManager` here, is not to break existing usage of `ObjectStoreProvider`. However, if not considering of existing usage of `ObjectStoreProvider`, I have no preference on whether to combine them into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
