felipecrv commented on code in PR #34408:
URL: https://github.com/apache/arrow/pull/34408#discussion_r1136397402
##########
cpp/src/arrow/array/array_test.cc:
##########
@@ -78,20 +79,58 @@ class TestArray : public ::testing::Test {
MemoryPool* pool_;
};
+template <class ScalarType>
+std::shared_ptr<ScalarType> MakeScalar(typename ScalarType::ValueType value) {
+ return std::make_shared<ScalarType>(value);
+}
Review Comment:
I was having trouble getting it to work, but now I've realized I should have
just passed `int32_t` instead of `Int32Type` to the template. :)
So I'm removing it now in favor of scalar.h's version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
