felipecrv commented on code in PR #34408:
URL: https://github.com/apache/arrow/pull/34408#discussion_r1136408291
##########
cpp/src/arrow/array/array_test.cc:
##########
@@ -78,20 +79,58 @@ class TestArray : public ::testing::Test {
MemoryPool* pool_;
};
+template <class ScalarType>
+std::shared_ptr<ScalarType> MakeScalar(typename ScalarType::ValueType value) {
+ return std::make_shared<ScalarType>(value);
+}
+
TEST_F(TestArray, TestNullCount) {
// These are placeholders
auto data = std::make_shared<Buffer>(nullptr, 0);
auto null_bitmap = std::make_shared<Buffer>(nullptr, 0);
- std::unique_ptr<Int32Array> arr(new Int32Array(100, data, null_bitmap, 10));
+ std::shared_ptr<Int32Array> arr(new Int32Array(100, data, null_bitmap, 10));
+ ASSERT_EQ(10, arr->ComputeLogicalNullCount());
ASSERT_EQ(10, arr->null_count());
+ ASSERT_TRUE(arr->data()->MayHaveNulls());
+ ASSERT_TRUE(arr->data()->MayHaveLogicalNulls());
- std::unique_ptr<Int32Array> arr_no_nulls(new Int32Array(100, data));
+ std::shared_ptr<Int32Array> arr_no_nulls(new Int32Array(100, data));
+ ASSERT_EQ(0, arr_no_nulls->ComputeLogicalNullCount());
ASSERT_EQ(0, arr_no_nulls->null_count());
+ ASSERT_FALSE(arr_no_nulls->data()->MayHaveNulls());
+ ASSERT_FALSE(arr_no_nulls->data()->MayHaveLogicalNulls());
- std::unique_ptr<Int32Array> arr_default_null_count(
+ std::shared_ptr<Int32Array> arr_default_null_count(
new Int32Array(100, data, null_bitmap));
ASSERT_EQ(kUnknownNullCount, arr_default_null_count->data()->null_count);
+ ASSERT_TRUE(arr_default_null_count->data()->MayHaveNulls());
+ ASSERT_TRUE(arr_default_null_count->data()->MayHaveLogicalNulls());
+
+ RunEndEncodedBuilder ree_builder(pool_,
std::make_shared<Int32Builder>(pool_),
Review Comment:
I mentioned you in PR comments pointing to code that tests `IsNull/Valid`
for unions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
