yevgenypats commented on code in PR #34558:
URL: https://github.com/apache/arrow/pull/34558#discussion_r1136939955
##########
go/arrow/csv/reader.go:
##########
@@ -469,6 +469,10 @@ func (r *Reader) initFieldConverter(bldr array.Builder)
func(string) {
return func(s string) {
r.parseList(bldr, s)
}
+ case arrow.BinaryDataType:
+ return func(s string) {
+ r.parseBinaryDataType(bldr, s)
Review Comment:
I handled it a bit differently as `""` shouldn't mean null in base64 but
rather just empty and `(null)` is not a valid base64 encoding anyway so we
don't really need to check the `r.StringsCanBeNull`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
