alamb commented on code in PR #5616:
URL: https://github.com/apache/arrow-datafusion/pull/5616#discussion_r1137571604
##########
datafusion/common/src/table_reference.rs:
##########
@@ -35,7 +35,38 @@ impl<'a> std::fmt::Display for ResolvedTableReference<'a> {
}
}
-/// Represents a path to a table that may require further resolution
+/// [`TableReference`]s represent a multi part identifier (path) to a
+/// table that may require further resolution.
+///
+/// # Creating [`TableReference`]
+///
+/// When converting strings to [`TableReference`]s, the string is
Review Comment:
The SQL parsing behavior added in
https://github.com/apache/arrow-datafusion/pull/5343 is somewhat surprising so
I think it should be well documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]