alamb commented on code in PR #5616:
URL: https://github.com/apache/arrow-datafusion/pull/5616#discussion_r1140048270
##########
datafusion/common/src/table_reference.rs:
##########
@@ -80,14 +121,20 @@ impl std::fmt::Display for TableReference<'_> {
}
impl<'a> TableReference<'a> {
- /// Convenience method for creating a `Bare` variant of `TableReference`
+ /// Convenience method for creating a [`TableReference::Bare`]
+ ///
+ /// As described on [`TableReference`] this does *NO* parsing at
+ /// all, so "Foo.Bar" stays as a reference to the table named
+ /// "Foo.Bar" (rather than "foo"."bar")
pub fn bare(table: impl Into<Cow<'a, str>>) -> TableReference<'a> {
TableReference::Bare {
table: table.into(),
}
}
- /// Convenience method for creating a `Partial` variant of `TableReference`
+ /// Convenience method for creating a [`TableReference::Partial`].
+ ///
+ /// As described on [`TableReference`] this does parsing at all.
Review Comment:
```suggestion
/// As described on [`TableReference`] this does *NO* parsing at all.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
