alamb commented on code in PR #5615:
URL: https://github.com/apache/arrow-datafusion/pull/5615#discussion_r1137803274
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -217,19 +248,13 @@ impl LogicalPlanBuilder {
/// Convert a table provider into a builder with a TableScan
pub fn scan_with_filters(
- table_name: impl Into<String>,
+ table_name: impl Into<OwnedTableReference>,
table_source: Arc<dyn TableSource>,
projection: Option<Vec<usize>>,
filters: Vec<Expr>,
) -> Result<Self> {
let table_name = table_name.into();
- if table_name.is_empty() {
- return Err(DataFusionError::Plan(
- "table_name cannot be empty".to_string(),
- ));
- }
Review Comment:
🤔 the `TableReference` methods are infallable (don't return Result) so
making them fallable would be a substantial change. I will restore this check
and add some test coverage. Good spot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
