alamb commented on code in PR #5615:
URL: https://github.com/apache/arrow-datafusion/pull/5615#discussion_r1137803726
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1361,12 +1394,24 @@ mod tests {
#[test]
fn plan_builder_schema() {
let schema = employee_schema();
- let plan = table_scan(Some("employee_csv"), &schema, None).unwrap();
-
- let expected =
- DFSchema::try_from_qualified_schema("employee_csv",
&schema).unwrap();
+ let projection = None;
+ let plan =
+ LogicalPlanBuilder::scan("employee_csv", table_source(&schema),
projection)
+ .unwrap();
+ let expected = DFSchema::try_from_qualified_schema(
+ TableReference::bare("employee_csv"),
+ &schema,
+ )
+ .unwrap();
+ assert_eq!(&expected, plan.schema().as_ref());
- assert_eq!(&expected, plan.schema().as_ref())
+ // Note scan of "EMPLOYEE_CSV" is treated as a SQL identifer
+ // (and thus normalized to "employee"csv") as well
+ let projection = None;
Review Comment:
this test fails without the code in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
