yukkit commented on code in PR #5559:
URL: https://github.com/apache/arrow-datafusion/pull/5559#discussion_r1138207404
##########
datafusion/expr/src/utils.rs:
##########
@@ -69,6 +69,94 @@ pub fn grouping_set_expr_count(group_expr: &[Expr]) ->
Result<usize> {
}
}
+fn powerset<T>(slice: &[T]) -> Vec<Vec<&T>> {
Review Comment:
> Can you please add a docstring explaining what the expected output of this
function is intended to be?
>
> For example, is it https://en.wikipedia.org/wiki/Power_set?
I will add comments to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]