yukkit commented on PR #5559: URL: https://github.com/apache/arrow-datafusion/pull/5559#issuecomment-1471730541
> This looks good to me -- thank you @yukkit > > the only thing I think is needed is an error condition check (as in try to pass in 100 columns in a grouping set). If this is unreasonable (or will take too long) I think it should generate a runtime error to protect DataFusion @alamb FWIW. DataFusion is a fundamental query engine designed for inheritance by other products. I believe that the responsibility for implementing any necessary restrictions should lie with those who integrate it, as they have a better understanding of the customers and application scenarios. Therefore, we can afford to set a relatively high security threshold, as long as the process remains stable. I noticed that in Doris, the maximum number of distinct sets in the grouping sets clause is 64, while in PostgreSQL, it is 4096, and in DuckDB, it is 65535. Additionally, the maximum number of group expressions in the grouping_set clause is 65535 in DuckDB. I would appreciate your feedback on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
