mapleFU commented on PR #34511: URL: https://github.com/apache/arrow/pull/34511#issuecomment-1472446180
Hi @omrimallis There a two kinds of node during **write** mode: 1. `PrimitiveNode`: For primitive type, which would have physical type and correspond logical type. As you can see, in `PrimitiveNode::PrimitiveNode`, it will force set a logical_type 2. `GroupNode`: A node for Struct/Map/Array, it would have a logicalType, and never have a physical type. So, I think when writing, we always have a physical type. Things get a bit complex during reading. It will parse type from arrow, and need to handle compability. But `Node` in memory would have logical type. So, this patch relax checking when writing, but I guess logical_type is enough. If I'm wrong, please correct me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
