mslapek opened a new pull request, #5623: URL: https://github.com/apache/arrow-datafusion/pull/5623
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #3892 Removes a blocker for #4628 (allows to have only one `LogicalPlan` in RAM) Attractive alternative for returning `Option<LogicalPlan>` in the optimizer loop (see the comment https://github.com/apache/arrow-datafusion/issues/4628#issuecomment-1470106106) # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Explained in the issue. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Added a new structure `LogicalPlanSignature` with `compute` method. Used `LogicalPlanSignature` in the main optimization loop to detect cycles with hash-set. Additionally raised default `max_passes` in optimizer, because we can detect cycles. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> New unit-tests in the new module with `LogicalPlanSignature`. Existing tests for the optimizer loop. # Are there any user-facing changes? Changed default `max_passes` in optimizer. NO API changes. The new module with `LogicalPlanSignature` is **private** (`mod` vs `pub use`). <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
