[GitHub] [arrow-datafusion] mslapek commented on a diff in pull request #5623: Add LogicalPlanSignature and use in the optimizer loop

Sat, 18 Mar 2023 10:56:54 -0700 


mslapek commented on code in PR #5623:
URL: https://github.com/apache/arrow-datafusion/pull/5623#discussion_r1141080502


##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -419,6 +412,34 @@ impl Optimizer {
     }
 }
 
+/// Returns an error if plans have different schemas.

Review Comment:
   The Boy Scout Rule: "Leave the campground cleaner than you found it" 🤣



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to