wjones127 commented on code in PR #34591:
URL: https://github.com/apache/arrow/pull/34591#discussion_r1142544712
##########
cpp/src/arrow/adapters/orc/util.cc:
##########
@@ -1111,7 +1120,11 @@ Result<std::shared_ptr<DataType>> GetArrowType(const
liborc::Type* type) {
case liborc::CHAR:
return fixed_size_binary(static_cast<int>(type->getMaximumLength()));
case liborc::TIMESTAMP:
+ // The timestamp values stored in ORC are in the writer timezone.
return timestamp(TimeUnit::NANO);
Review Comment:
Okay that makes sense. It does make me wonder if we should then be applying
the local time zone to these types, instead of using naive timestamps:
```suggestion
// The timestamp values stored in ORC are in the writer timezone.
return timestamp(TimeUnit::NANO, GetLocalTimeZone());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
