wgtmac commented on code in PR #34591:
URL: https://github.com/apache/arrow/pull/34591#discussion_r1142849581
##########
cpp/src/arrow/adapters/orc/util.cc:
##########
@@ -1111,7 +1120,11 @@ Result<std::shared_ptr<DataType>> GetArrowType(const
liborc::Type* type) {
case liborc::CHAR:
return fixed_size_binary(static_cast<int>(type->getMaximumLength()));
case liborc::TIMESTAMP:
+ // The timestamp values stored in ORC are in the writer timezone.
return timestamp(TimeUnit::NANO);
Review Comment:
This would fail the equality check of timestamp types in the roundtrip
tests. Additionally, it seems that there is a lack of utility like
`GetLocalTimeZone()`?
IMHO, if writer uses naive timestamp types, reader should follow the same
pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
