alamb commented on code in PR #3891:
URL: https://github.com/apache/arrow-rs/pull/3891#discussion_r1142711327
##########
arrow-array/src/builder/mod.rs:
##########
@@ -132,9 +132,70 @@ pub trait ArrayBuilder: Any + Send {
fn into_box_any(self: Box<Self>) -> Box<dyn Any>;
}
-/// A list array builder with i32 offsets
+/// Builder for [`ListArray`]s (i32 offsets)
+///
+/// [`ListArray`]: crate::array::ListArray
+///
+/// # Example
+///
+/// ```
+/// # use arrow_array::builder::{StringBuilder, ListBuilder};
+/// # use arrow_array::ListArray;
+/// // Build a 3 element array of lists:
+/// //
+/// // column
+/// // ---------
+/// // {one},
Review Comment:
It is a good idea. I chose the `{` notation because it is what is used in
the pretty print output for ListArray
For example:
https://github.com/influxdata/influxdb_iox/blob/efae5246cf1f2cc13222593f669dc4af3039d0df/influxdb_iox/tests/end_to_end_cases/flightsql.rs#L184-L192
SHould I propose changing that too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
