tustvold commented on code in PR #3891:
URL: https://github.com/apache/arrow-rs/pull/3891#discussion_r1143200970


##########
arrow-array/src/builder/mod.rs:
##########
@@ -132,9 +132,70 @@ pub trait ArrayBuilder: Any + Send {
     fn into_box_any(self: Box<Self>) -> Box<dyn Any>;
 }
 
-/// A list array builder with i32 offsets
+/// Builder for [`ListArray`]s (i32 offsets)
+///
+/// [`ListArray`]: crate::array::ListArray
+///
+/// # Example
+///
+/// ```
+/// # use arrow_array::builder::{StringBuilder, ListBuilder};
+/// # use arrow_array::ListArray;
+/// // Build a 3 element array of lists:
+/// //
+/// // column
+/// // ---------
+/// // {one},

Review Comment:
   Confirmed
   
   - 
https://github.com/apache/arrow-rs/blob/master/arrow-cast/src/pretty.rs#L291
   - 
https://github.com/apache/arrow-rs/blob/master/arrow-json/src/raw/mod.rs#L668
   
   Although I do realise our test coverage of this is fairly limited...
   
   That looks like the output of a UnionArray tbh?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to