dinimar commented on code in PR #34537:
URL: https://github.com/apache/arrow/pull/34537#discussion_r1143167786


##########
cpp/src/arrow/type_test.cc:
##########
@@ -379,6 +382,72 @@ TEST(TestFieldPath, Basics) {
                                   FieldPath({s.num_fields() * 2}).Get(s));
 }
 
+TEST(TestFieldPath, GetForTable) {

Review Comment:
   @benibus In case there are several ways to create schema and table objects 
it would be reasonable to add separate test cases for each. At the moment, I 
don't have required level of expertise to add them. So, it would be great if 
you add commit suggestions or push your code with tests directly in my 
repository
   
   Feel free to ask me if you will have problems with pushing your code to my 
fork



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to