mapleFU commented on code in PR #34526:
URL: https://github.com/apache/arrow/pull/34526#discussion_r1143228128
##########
cpp/src/parquet/encoding.cc:
##########
@@ -2883,7 +2989,26 @@ class RleBooleanDecoder : public DecoderImpl, virtual
public BooleanDecoder {
int DecodeArrow(int num_values, int null_count, const uint8_t* valid_bits,
int64_t valid_bits_offset,
typename EncodingTraits<BooleanType>::Accumulator* out)
override {
- ParquetException::NYI("DecodeArrow for RleBooleanDecoder");
+ if (null_count != 0) {
+ ParquetException::NYI("RleBoolean DecodeArrow with null slots");
Review Comment:
Yes...Here implement it just for testing. And later `DecodeArrow with null
slots` not have todo. I may do it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]