mapleFU commented on code in PR #34526:
URL: https://github.com/apache/arrow/pull/34526#discussion_r1143456517
##########
cpp/src/parquet/encoding.cc:
##########
@@ -489,6 +489,10 @@ class DictEncoderImpl : public EncoderImpl, virtual public
DictEncoder<DType> {
public:
typedef typename DType::c_type T;
+ /// In data page, the bit width used to encode the entry
+ /// ids stored as 1 byte (max bit width = 32).
+ constexpr static int32_t kDataPageBitWidthBytes = 1;
Review Comment:
@wgtmac I extract that `1` to a `kDataPageBitWidthBytes` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
