velvia commented on pull request #8688: URL: https://github.com/apache/arrow/pull/8688#issuecomment-732451343
@jorgecarleitao and others: - All outstanding issues should be resolved now, including the nonzero array offsets - Rebased to latest master as of today - I did not make the nullif kernel more generic, the reason is that I took @vertexclique 's suggestion to slice the left array data buffer, which allows us to work with the shifted/0-based null combined bitmaps. The result of this is that we must assume that the data buffers are primitive, otherwise shifting/slicing the data buffers might not work for non primitive types or be more complex. Let me know what you think. The alternative is to re-shift the combined bitmaps back to `left.offset()`, which might have space implications, but would be more generic (would not require any change of the left array's data buffers), and would have to wait for the other PR as well most likely.... I personally would prefer not to wait :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
