wyzhao commented on a change in pull request #8672:
URL: https://github.com/apache/arrow/pull/8672#discussion_r529065377
##########
File path: python/pyarrow/parquet.py
##########
@@ -871,21 +889,34 @@ def filter_accepts_partition(self, part_key, filter,
level):
if p_column != f_column:
return True
- f_type = type(f_value)
+ p_value = self.levels[level].dictionary[p_value_index].as_py()
- if isinstance(f_value, set):
+ if op in {'in', 'not in'}:
+ if not (isinstance(f_value, Container) and
+ isinstance(f_value, Iterable)):
Review comment:
Now ('part', 'in', 'abc') will be True for 'a', 'b', 'ab' or 'abc'.
There is a new test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
