thinkharderdev commented on code in PR #5692:
URL: https://github.com/apache/arrow-datafusion/pull/5692#discussion_r1145180603
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -2386,6 +2386,15 @@ mod roundtrip_tests {
roundtrip_expr_test(test_expr, ctx);
}
+ #[test]
Review Comment:
not sure I follow. `Expr::Cast` was already handled. With this PR we should
also be able to serialize `Expr::TryCast` so any valid expression should be
serializable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
