comphead commented on code in PR #5692:
URL: https://github.com/apache/arrow-datafusion/pull/5692#discussion_r1145449399
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -2386,6 +2386,15 @@ mod roundtrip_tests {
roundtrip_expr_test(test_expr, ctx);
}
+ #[test]
Review Comment:
oh wow, lol :) , in PG such query doesn't work
```
❯ select 1::float::boolean;
+----------+
| Int64(1) |
+----------+
| true |
+----------+
1 row in set. Query took 0.005 seconds.
```
PG: `cannot cast type double precision to boolean`
so then we probably can have a negative test to round trip try cast from
string "blabla" to boolean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
