zeroshade commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1145386530
##########
go/internal/types/uuid.go:
##########
@@ -0,0 +1,198 @@
+package types
+
+import (
+ "bytes"
+ "fmt"
+ "reflect"
+ "strings"
+
+ "github.com/goccy/go-json"
+
+ "github.com/apache/arrow/go/v12/arrow"
+ "github.com/apache/arrow/go/v12/arrow/array"
+ "github.com/google/uuid"
+)
+
+type UUIDBuilder struct {
+ *array.ExtensionBuilder
+}
Review Comment:
instead of this being duplicated now in `arrow/internal/testing/types/` and
here, could we remove it from `arrow/internal/testing/types/` and anywhere that
references `UUIDType` in the arrow pkg also points to this spot? That way both
are sharing this implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
