zeroshade commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1145388909
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -1526,6 +1528,7 @@ func TestWriteTableMemoryAllocation(t *testing.T) {
arrow.Field{Name: "i64", Type:
arrow.PrimitiveTypes.Int64, Nullable: true},
arrow.Field{Name: "f64", Type:
arrow.PrimitiveTypes.Float64, Nullable: true})},
{Name: "arr_i64", Type:
arrow.ListOf(arrow.PrimitiveTypes.Int64)},
+ {Name: "uuid", Type: types.NewUUIDType(), Nullable: true},
Review Comment:
please add this to one of the round trip tests (this test doesn't perform a
read) so that we have full testing for reading *and* writing the extension type
along with confirmation that the resulting Array we read matches what we wrote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
