alamb commented on code in PR #3918:
URL: https://github.com/apache/arrow-rs/pull/3918#discussion_r1146822972
##########
arrow-ord/src/sort.rs:
##########
@@ -1159,8 +1159,13 @@ pub struct LexicographicalComparator<'a> {
impl LexicographicalComparator<'_> {
/// lexicographically compare values at the wrapped columns with given
indices.
pub fn compare(&self, a_idx: usize, b_idx: usize) -> Ordering {
- for (data, comparator, sort_option) in &self.compare_items {
- match (data.is_valid(a_idx), data.is_valid(b_idx)) {
+ for (nulls, comparator, sort_option) in &self.compare_items {
Review Comment:
I checked at this seems to simply pull the `match` up a level
https://docs.rs/arrow-data/35.0.0/src/arrow_data/data/mod.rs.html#384-389 (as
in there is no more dynamic dispatch from what I can see)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
