alamb commented on code in PR #3918:
URL: https://github.com/apache/arrow-rs/pull/3918#discussion_r1146829103
##########
arrow-arith/src/boolean.rs:
##########
@@ -381,29 +313,12 @@ pub fn not(left: &BooleanArray) -> Result<BooleanArray,
ArrowError> {
/// assert_eq!(a_is_null, BooleanArray::from(vec![false, false, true]));
/// ```
pub fn is_null(input: &dyn Array) -> Result<BooleanArray, ArrowError> {
- let len = input.len();
-
- let output = match input.data_ref().nulls() {
- None => {
- let len_bytes = ceil(len, 8);
- MutableBuffer::from_len_zeroed(len_bytes).into()
- }
- Some(nulls) => buffer_unary_not(nulls.buffer(), nulls.offset(),
nulls.len()),
+ let values = match input.nulls() {
+ None => NullBuffer::new_null(input.len()).into_inner(),
+ Some(nulls) => !nulls.inner(),
Review Comment:
these certainly do look very nice now 👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
